[Common,PWGCF] EventPlaneHelper: avoid copying FT0 Geometry on every call#16444
Open
ktf wants to merge 1 commit into
Open
[Common,PWGCF] EventPlaneHelper: avoid copying FT0 Geometry on every call#16444ktf wants to merge 1 commit into
ktf wants to merge 1 commit into
Conversation
GetPhiFT0 and SumQvectors took o2::ft0::Geometry by value, causing a full copy (TObject heap allocation + destruction) on every invocation. SumQvectors is called ~208 times per event, so this was ~14% of CPU in Q-vector trains. Additionally, calculateChannelCenter() was called inside GetPhiFT0 on every channel, recomputing all 208 channel positions from scratch each time despite the geometry being constant. Fix: - Pass ft0::Geometry by const reference - Call calculateChannelCenter() once at init time - Remove the per-call calculateChannelCenter() from GetPhiFT0
ktf
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jaelpark,
jgrosseo,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
|
O2 linter results: ❌ 13 errors, |
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetPhiFT0 and SumQvectors took o2::ft0::Geometry by value,
causing a full copy (TObject heap allocation + destruction) on
every invocation. SumQvectors is called ~208 times per event,
so this was ~14% of CPU in Q-vector trains.
Additionally, calculateChannelCenter() was called inside
GetPhiFT0 on every channel, recomputing all 208 channel
positions from scratch each time despite the geometry being
constant.
Fix: